Skip to content

8369178: G1: Use NMethodMarkingScope and ThreadsClaimTokenScope in G1RootProcessor #27644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8369178: G1: Use NMethodMarkingScope and ThreadsClaimTokenScope in G1RootProcessor #27644

wants to merge 2 commits into from
+14 −46

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Oct 6, 2025 •
edited by openjdk bot
Loading

Replace StrongRootsScope with ThreadsClaimTokenScope and MarkingNMethodClosure in G1RootProcessor to be more precise with what is needed and why.

  • MarkingNMethodClosure is used in G1FullGCMarkTask, so we also need NMethodMarkingScope.
  • active_workers is guaranteed to be > 0

Passes tier1 and tier2 (fastdebug).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369178: G1: Use NMethodMarkingScope and ThreadsClaimTokenScope in G1RootProcessor (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27644/head:pull/27644
$ git checkout pull/27644

Update a local copy of the PR:
$ git checkout pull/27644
$ git pull https://git.openjdk.org/jdk.git pull/27644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27644

View PR using the GUI difftool:
$ git pr show -t 27644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27644.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2025

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2025 •
edited
Loading

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369178: G1: Use NMethodMarkingScope and ThreadsClaimTokenScope in G1RootProcessor

Reviewed-by: ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@fandreuz The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2025

Webrevs

albertnetymk
albertnetymk approved these changes Oct 6, 2025
View reviewed changes
src/hotspot/share/gc/g1/g1RootProcessor.hpp
StrongRootsScope _srs;
NMethodMarkingScope _nmethod_marking_scope;
ThreadsClaimTokenScope _threads_claim_token_scope;
bool _is_parallel;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used uint _num_workers, but I guess this also works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to know how many workers there are, just if we are parallel or not. I think this goes in the same direction as the idea of the PR, being clear about what we actually need

@albertnetymk
Copy link
Member

/cc hotspot-gc

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-gc [email protected] labels Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@albertnetymk
The hotspot-gc label was successfully added.

@fandreuz
Copy link
Contributor Author

fandreuz commented Oct 7, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@fandreuz
Your change (at version 131f636) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@albertnetymk albertnetymk albertnetymk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
hotspot [email protected] hotspot-gc [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fandreuz @albertnetymk